Fix IsStringEnumArray for nullable enum arrays#1904
Merged
lahma merged 1 commit intoRicoSuter:masterfrom Mar 8, 2026
Merged
Conversation
Use ActualTypeSchema instead of ActualSchema when resolving array item schema, so that nullable oneOf wrappers are properly resolved to the underlying enum type. This matches the existing pattern used by IsStringEnum. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ca7aa01 to
2183c15
Compare
This was referenced Apr 8, 2026
Merged
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsStringEnumArrayreturnedfalseforList<MyEnum?>because.Item.ActualSchemadoesn't resolve through nullableoneOfwrappers.Item.ActualTypeSchema(2 occurrences), which filters out the null entry inoneOfwrappers — matching the existing pattern used byIsStringEnumTest plan
When_nullable_enum_array_then_IsStringEnumArray_is_truewith a JSON schema containing a nullable enum array (oneOf: [null, $ref enum]in items)StringEnumConverter🤖 Generated with Claude Code