Fix ObsoleteAttribute not applied to classes with a base class#1902
Merged
lahma merged 1 commit intoRicoSuter:masterfrom Mar 7, 2026
Merged
Fix ObsoleteAttribute not applied to classes with a base class#1902lahma merged 1 commit intoRicoSuter:masterfrom
lahma merged 1 commit intoRicoSuter:masterfrom
Conversation
When a class uses allOf for inheritance, the deprecated/x-deprecated flag may be on an allOf sub-schema rather than the root schema. The ClassTemplateModel only checked the root schema's IsDeprecated property. Now checks both the root schema and allOf sub-schemas for deprecated status and message. Fixes RicoSuter#1820 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 8, 2026
Merged
This was referenced Apr 20, 2026
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allOffor inheritance, thedeprecated/x-deprecatedflag may be on anallOfsub-schema rather than the root schemaClassTemplateModel.IsDeprecatedonly checked_schema.IsDeprecated, missing deprecation in allOf sub-schemasallOfsub-schemas for deprecated status and messageTest plan
ObsoleteTests.cs:x-deprecated: true+x-deprecatedMessagein allOf →[Obsolete("message")]renderedx-deprecated: true(no message) in allOf →[Obsolete]renderedFixes #1820
🤖 Generated with Claude Code