Skip to content

Fix '#' in typescript property names #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Fix '#' in typescript property names #1778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/NJsonSchema.CodeGeneration.TypeScript/TypeScriptPropertyNameGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace NJsonSchema.CodeGeneration.TypeScript
public sealed class TypeScriptPropertyNameGenerator : IPropertyNameGenerator
{
private static readonly char[] _reservedFirstPassChars = ['"', '@', '?', '.', '=', '+'];
private static readonly char[] _reservedSecondPassChars = ['*', ':', '-'];
private static readonly char[] _reservedSecondPassChars = ['*', '#', ':', '-'];

/// <summary>Gets or sets the reserved names.</summary>
public HashSet<string> ReservedPropertyNames { get; set; } = new(StringComparer.Ordinal) { "constructor", "init", "fromJS", "toJSON" };
Expand All @@ -37,6 +37,7 @@ public string Generate(JsonSchemaProperty property)
if (name.IndexOfAny(_reservedSecondPassChars) != -1)
{
name = name.Replace("*", "Star")
.Replace("#", "_")
.Replace(":", "_")
.Replace("-", "_");
}
Expand All @@ -49,4 +50,4 @@ public string Generate(JsonSchemaProperty property)
return name;
}
}
}
}
Loading