-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes/mid revision #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
revision
optional parameter of MIDs constructors is no longer optional since the default is always 1, if a revision is desired you should pass it as parameterValidate()
method that existed in some Mids were removed.Datafields
enum are now protected, since it belongs only to the mid itself, you should not use externally.PowerMacsStatuses
enum fromMid0107
and now uses thePowerMacsStatus
enum-
characters are interpreted as_
)OpenEndData
class outside ofMid0041
ToolType
enum changed accordingly with documentation,IPT
refers to code30
in place ofQSHIELD_C
IValueConverter<T>
was removed and converted to static functions atOpenProtocolConvert
or a protected virtual method at the unique mid that needs itPaddingOrientations
enum is no longer insideDataField
class and changed toPaddingOrientation
Improvements
New Features
Mid0009
Mid0702
Mid0703
Mid2505
AutoSelect
enumJobTighteningStatus
enumResultType
enumSystemType
enumFixes
Mid1201
(MID1201 #90)Mid1202
to consider header length instead o package length to avoid NUL (MID1202 Failed Parsing due Incorrect Length Size #94)Mid0006
Mid0008
Mid0091
Mid0106
Mid0107
Mid0215
Mid0240
Mid0242
Mid0251
Related issues