Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Link Level acknowledging or not clear the usage example #88

Closed
roniinterconetica opened this issue Apr 12, 2022 · 3 comments
Closed
Assignees
Labels

Comments

@roniinterconetica
Copy link

First I would like top congratulate you for this project. It's very nice!
Based on the vresion 2.8 and newers versions of protocol , (3.2.2 Link Level acknowledging method from OP spec. 2.0 page 38)
Is possible to use sequence in headers to check correctly the message interchange.
As the protocol says
"OBS! It is really recommended and almost a mandatory to use this method instead of Application Method acknowledging due to a lot of customer reported problems during the years of OP existence, which will be solved by this OBS!."

For Example :

image

How should I use the OpenProtocolInterpreter with sequence acknowledging ?
Is it possible and implemented in all messages ?

Thank you a lot !

@Rickedb
Copy link
Owner

Rickedb commented Apr 17, 2022

Hello @roniinterconetica and sorry for the delay, been out since last week.

The Header part was developed at 2017 and I probably misunderstood the concept, which was translated wrongly as UsedAs in the library.

But answering your question, yes, it's possible to use, however it will be annoying for you to use it in the way it's working right now.

I'm going to work in a new version to fix this.

@Rickedb Rickedb added the bug label Apr 17, 2022
@Rickedb Rickedb self-assigned this Apr 17, 2022
@roniinterconetica
Copy link
Author

You are great @Rickedb !

@Rickedb
Copy link
Owner

Rickedb commented Jun 6, 2022

@roniinterconetica Sorry for the delay, was in a rush since April. But version 5.0.0 is out now, any problems please contact me or write an issue.

For more information, please check the release notes: https://github.com/Rickedb/OpenProtocolInterpreter/releases/tag/5.0.0

@Rickedb Rickedb closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants