chore(common): re-pin Common 9691bd8 + drift gate (LOOP-001) - #344
Merged
Merged
Conversation
…(LOOP-001) Advances the Common pin 3f8c4df → 9691bd8, adopting the security PRs that landed after the R2-02 pin: MediaRedirectSafeSender pre-send validation (#622), SafeDirectoryCleanup reparse-point refusal (#623), TimeParsing helpers (#624). Adds CommonPinDriftTests (parity): asserts ext-common-sha.txt equals the checked-out ext/Lidarr.Plugin.Common HEAD, so the sentinel and the Common actually built can't drift apart (the apple failure mode). Compares against the checked-out submodule HEAD (not the committed gitlink) so it holds in a dirty local re-pin and still catches a forgot-to-stage submodule in a clean CI checkout. Skips when git is unavailable. The #622 pre-send validation correctly rejects the stub host "https://chunk" in the DI end-to-end download-validation test (it doesn't resolve under the Strict guard); injected TidalTestPolicies.Resolving there to match the R2-02 test sweep. 1323 unit + 38 parity green (incl. the 2 new drift gates). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOOP-001 — converge tidal's Common pin + gate future drift
Re-pins
ext/Lidarr.Plugin.Common3f8c4df→9691bd8, adopting the post-R2-02 security PRs (#622 pre-send SSRF validation, #623 reparse-point refusal, #624 TimeParsing).Adds
CommonPinDriftTests(parity):ext-common-sha.txtmust equal the checked-out submodule HEAD. This fails the apple-style divergence (sentinel says one SHA, submodule is another). It compares against the checked-out submodule rather than the committed gitlink so it holds during a dirty local re-pin and catches a forgot-to-stage-submodule in a clean CI checkout. Skips when git is unavailable.The #622 pre-send validation correctly rejects the stub host
https://chunkinDI_Flow_IndexerSearch_And_DownloadValidation_Work(doesn't resolve under the Strict guard) — injectedTidalTestPolicies.Resolvingthere, matching the R2-02 test sweep.1323 unit + 38 parity green (incl. the 2 new drift gates).
🤖 Generated with Claude Code