Skip to content

fix(ci): Governance Quarantine Visibility builds hostless (fix CS0234 LidarrNative) #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RicherTunes merged 2 commits into from
Jun 1, 2026
Merged

fix(ci): Governance Quarantine Visibility builds hostless (fix CS0234 LidarrNative) #319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d071571
fix(ci): build hostless in Governance Quarantine Visibility job
RicherTunes Jun 1, 2026
5ef9436
fix(ci): build Governance QTV job against real Lidarr host assemblies
RicherTunes Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions .github/workflows/governance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,33 +128,39 @@ jobs:
restore-keys: |
${{ runner.os }}-nuget-

- name: Prepare host stub assemblies
shell: pwsh
- name: Setup Lidarr host assemblies (Docker, plugins branch)
shell: bash
run: |
$commonScripts = Join-Path $PWD 'ext/Lidarr.Plugin.Common/scripts'
$hostOutput = Join-Path $PWD 'ext/Lidarr/_output/net8.0'
if (Test-Path $commonScripts) {
$prepareStub = Join-Path $commonScripts 'prepare-host-stub.ps1'
if (Test-Path $prepareStub) {
Write-Host "Generating host stub assemblies..."
& $prepareStub -OutputPath $hostOutput
}
}
set -e
mkdir -p ext/Lidarr/_output/net8.0
if ! docker --version >/dev/null 2>&1; then echo "::error::Docker required to fetch Lidarr host assemblies"; exit 1; fi
IMAGE="ghcr.io/hotio/lidarr:pr-plugins-3.1.2.4913"
n=0; until docker pull "$IMAGE"; do n=$((n+1)); if [ "$n" -ge 3 ]; then echo "::error::docker pull failed after $n attempts ($IMAGE)"; exit 1; fi; echo "pull failed ($n), retry in 10s"; sleep 10; done
cid=$(docker create "$IMAGE")
docker cp "$cid:/app" ext/Lidarr/_extracted || docker cp "$cid:/opt/lidarr" ext/Lidarr/_extracted
docker rm "$cid" >/dev/null
find ext/Lidarr/_extracted -type f -name "*.dll" -exec cp {} ext/Lidarr/_output/net8.0 \;
test -f ext/Lidarr/_output/net8.0/Lidarr.dll || { echo "::error::Lidarr.dll missing after extraction"; exit 1; }
echo "Extracted $(ls ext/Lidarr/_output/net8.0/*.dll | wc -l) host assemblies"

- name: Restore and build
shell: bash
run: |
dotnet restore src/Tidalarr/Tidalarr.csproj
# Build the FULL plugin (incl. LidarrNative host-bridge) against the real
# Lidarr host assemblies extracted above. TidalModule.cs references the
# LidarrNative namespace unconditionally, so the host-bridge cannot be
# excluded — SkipHostBridge stub mode would drop LidarrNative/** and break
# with CS0234. Mirrors ci.yml / test-and-coverage.yml / nightly.yml.
dotnet build src/Tidalarr/Tidalarr.csproj --configuration Release --no-restore \
-p:RunAnalyzersDuringBuild=false -p:EnableNETAnalyzers=false

- name: Build test project (exclude HostBridge)
- name: Build test project
shell: bash
run: |
dotnet build tests/Tidalarr.Tests/Tidalarr.Tests.csproj \
--configuration Release -v minimal \
-p:RunAnalyzersDuringBuild=false -p:EnableNETAnalyzers=false \
-p:SkipHostBridge=true -p:ExcludeHostBridge=true
-p:RunAnalyzersDuringBuild=false -p:EnableNETAnalyzers=false

- name: Run quarantined tests (visibility)
continue-on-error: true
Expand All @@ -167,8 +173,7 @@ jobs:
--blame-hang-timeout 60s \
--logger "trx;LogFileName=quarantined.trx" \
--results-directory ./TestResults \
-p:PluginPackagingDisable=true \
-p:SkipHostBridge=true
-p:PluginPackagingDisable=true

- name: Report quarantine count
if: always()
Expand Down
Loading