fix: wave 1 hardening — OAuth logging, net8 docs, market config - #251
Merged
Merged
Conversation
- OAuthTokenProviderAdapter: replace bare catch blocks with NLog warnings that capture the exception, aiding auth failure diagnosis - CLAUDE.md / TFM_RATIONALE.md: update stale net6.0 references to net8.0 to match the actual target framework - TidalSearchService: replace hardcoded "US" market with configurable parameter (default "US"); TidalIndexer now passes Settings.TidalMarket Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
RicherTunes
added a commit
that referenced
this pull request
May 28, 2026
fix: wave 1 hardening — OAuth logging, net8 docs, market config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch { return ... }blocks withcatch (Exception ex)+ NLogWarn-level logging, so OAuth failures are no longer silently swallowednet6.0references tonet8.0to match the actual target frameworkmarketparameter (default"US") toSearchWithQualityDetectionAsyncandSearchByTypeAsync;TidalIndexernow passesSettings.TidalMarketthrough to the optimizer'sQueryContext.CountryTest plan
dotnet buildsucceeds with 0 warnings, 0 errorsdotnet testpasses 292/292 tests (17 expected skips for CLI/packaging/Docker)🤖 Generated with Claude Code