fix: stop silently swallowing exceptions in indexer search methods - #249
Merged
Merged
Conversation
…lowing The indexer's SearchAlbumsAsync, SearchTracksInternalAsync, GetAlbumDetailsInternalAsync, and SearchEnhancedAsync methods caught exceptions, reported them via bridge reporters, then returned empty results. This silently hid failures from callers — Lidarr would show zero results with no indication that an error occurred. After this change, all four methods still report errors through the bridge reporters (IIndexerStatusReporter) but rethrow instead of returning empty collections. This lets Lidarr surface auth failures, rate limits, and API errors to users. The happy path is unchanged. GetAlbumDetailsInternalAsync also gains bridge reporter calls in its catch block (previously only logged) and SearchEnhancedAsync gains the same reporter integration for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
RicherTunes
added a commit
that referenced
this pull request
May 28, 2026
fix: stop silently swallowing exceptions in indexer search methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[]or a defaultStreamingAlbum). This silently hid API failures, auth errors, and rate limits from callers -- Lidarr would show zero results with no indication anything went wrong.IIndexerStatusReporter, so callers (Lidarr) can surface errors to users and apply retry logic.IIndexerStatusReporter.ReportErrorAsynccalls in its catch block (previously it only logged) and SearchEnhancedAsync gains the same reporter integration for consistency.GetAlbumDetailsInternalAsyncis moved inside the try block since it is only needed when the API call succeeds but mapping returns null -- it should not mask exceptions.Test plan
main)🤖 Generated with Claude Code