ci: migrate to unified test runner

.github/workflows/ci.yml

@@ -113,7 +113,9 @@ jobs:
         if: github.event_name == 'pull_request'
         shell: pwsh
         run: |
-          dotnet format Tidalarr.sln --verify-no-changes -v minimal --exclude ext --exclude temp
+          # Exclude LidarrNative files and test files that reference them -
+          # they use host types not available in clean checkout
+          dotnet format Tidalarr.sln --verify-no-changes -v minimal --exclude ext --exclude temp --exclude 'src/Tidalarr/Integration/LidarrNative' --exclude 'tests/Tidalarr.Tests/Unit/TidalLidarrDownloadClientGuidParsingTests.cs' --exclude 'tests/Tidalarr.Tests/Unit/TidalLidarrIndexerSizeEstimationTests.cs'
 
       - name: Run unified plugin pipeline
         shell: pwsh

.github/workflows/packaging-closure.yml

@@ -56,26 +56,31 @@ jobs:
         shell: pwsh
         continue-on-error: ${{ github.event_name != 'pull_request' }}
         run: |
-          dotnet format Tidalarr.sln --verify-no-changes -v minimal --exclude ext --exclude temp
+          # Exclude LidarrNative files and test files that reference them -
+          # they use host types not available in clean checkout
+          dotnet format Tidalarr.sln --verify-no-changes -v minimal --exclude ext --exclude temp --exclude 'src/Tidalarr/Integration/LidarrNative' --exclude 'tests/Tidalarr.Tests/Unit/TidalLidarrDownloadClientGuidParsingTests.cs' --exclude 'tests/Tidalarr.Tests/Unit/TidalLidarrIndexerSizeEstimationTests.cs'
 
       - name: Build (Release)
         shell: pwsh
         run: |
-          # Build only plugin projects, exclude HostBridge which requires full Lidarr assemblies
+          # Build plugin with SkipHostBridge=true to exclude LidarrNative files that require host assemblies
           dotnet build src/Tidalarr/Tidalarr.csproj -c Release -v minimal `
             -p:RunAnalyzersDuringBuild=false `
             -p:EnableNETAnalyzers=false `
-            -p:TreatWarningsAsErrors=false
+            -p:TreatWarningsAsErrors=false `
+            -p:SkipHostBridge=true
+          # TidalCLI references Tidalarr - must also pass SkipHostBridge to avoid rebuilding with LidarrNative
           dotnet build TidalCLI/TidalCLI.csproj -c Release -v minimal `
             -p:RunAnalyzersDuringBuild=false `
             -p:EnableNETAnalyzers=false `
-            -p:TreatWarningsAsErrors=false
+            -p:TreatWarningsAsErrors=false `
+            -p:SkipHostBridge=true
 
       - name: Verify dependency closure
         shell: pwsh
         run: |
-          # Verify from build output (ILRepack packaging not available in CI)
-          $outputDir = Join-Path $env:GITHUB_WORKSPACE 'src/Tidalarr/bin/Release/net8.0'
+          # Verify from build output - Tidalarr uses OutputPath=bin\ without configuration subdirectory
+          $outputDir = Join-Path $env:GITHUB_WORKSPACE 'src/Tidalarr/bin'
           if (-not (Test-Path $outputDir)) { Write-Error "Build output not found: $outputDir"; exit 1 }
           $dlls = Get-ChildItem $outputDir -Filter *.dll | ForEach-Object { $_.Name }
           $allowed = @('Lidarr.Plugin.Tidalarr.dll','Lidarr.Plugin.Common.dll','Lidarr.Plugin.Abstractions.dll')
@@ -89,9 +94,8 @@ jobs:
         with:
           name: plugin-build
           path: |
-            src/Tidalarr/bin/Release/net8.0/Lidarr.Plugin.Tidalarr.dll
-            src/Tidalarr/bin/Release/net8.0/Lidarr.Plugin.Tidalarr.pdb
-            src/Tidalarr/bin/Release/net8.0/Lidarr.Plugin.Common.dll
+            src/Tidalarr/bin/Lidarr.Plugin.Tidalarr.dll
+            src/Tidalarr/bin/Lidarr.Plugin.Tidalarr.pdb
             plugin.json
 
 

.github/workflows/packaging-gates.yml

@@ -21,11 +21,11 @@ on:
 
 jobs:
   packaging-gates:
-    uses: RicherTunes/Lidarr.Plugin.Common/.github/workflows/packaging-gates.yml@8b538e7a5ee5f286c08e34261e30c9a1ac57f24e
+    uses: RicherTunes/Lidarr.Plugin.Common/.github/workflows/packaging-gates.yml@8344b04e142281466aa2fc6cb1d916f040e954bf
     with:
       common-path: ext/Lidarr.Plugin.Common
       plugin-csproj: src/Tidalarr/Tidalarr.csproj
       manifest-path: plugin.json
       plugin-load-gate: true
     secrets:
-      submodules-token: ${{ secrets.SUBMODULES_TOKEN }}
+      submodules-token: ${{ secrets.CROSS_REPO_PAT }}

.github/workflows/test-and-coverage.yml

@@ -90,25 +90,22 @@ jobs:
           dotnet build src/Tidalarr/Tidalarr.csproj --configuration Release --no-restore \
             -p:RunAnalyzersDuringBuild=false -p:EnableNETAnalyzers=false
 
-      - name: Build tests
-        shell: bash
-        run: |
-          dotnet restore tests/Tidalarr.Tests/Tidalarr.Tests.csproj -p:SkipHostBridge=true
-          dotnet build tests/Tidalarr.Tests/Tidalarr.Tests.csproj --configuration Release --no-restore \
-            -p:SkipHostBridge=true -p:RunAnalyzersDuringBuild=false -p:EnableNETAnalyzers=false
-
-      - name: Run tests with coverage
-        shell: bash
+      - name: Run tests with coverage (unified runner)
+        shell: pwsh
         run: |
-          mkdir -p TestResults
-          dotnet test tests/Tidalarr.Tests/Tidalarr.Tests.csproj \
-            --configuration Release \
-            --no-build \
-            --collect "XPlat Code Coverage" \
-            --logger "trx;LogFileName=test-results.trx" \
-            --results-directory TestResults/ \
-            --filter "scope!=cli" \
-            -p:SkipHostBridge=true
+          $runner = Join-Path $PWD 'ext/Lidarr.Plugin.Common/scripts/test.ps1'
+          if (-not (Test-Path $runner)) {
+            Write-Error "Unified test runner not found at: $runner"
+            exit 1
+          }
+          & $runner `
+            -TestProject 'tests/Tidalarr.Tests/Tidalarr.Tests.csproj' `
+            -Configuration Release `
+            -Coverage `
+            -CI `
+            -OutputDir 'TestResults' `
+            -AdditionalFilter 'scope!=cli' `
+            -Properties @('SkipHostBridge=true')
 
       - name: Install ReportGenerator
         shell: bash

Directory.Build.props

@@ -12,6 +12,19 @@
     <ILRepackEnabled>false</ILRepackEnabled>
   </PropertyGroup>
 
+  <!-- SkipHostBridge: Exclude Lidarr-native files in hostless/CI builds.
+       Auto-detect: when host stub assemblies are not present, skip host bridge automatically.
+       This allows PluginPack (packaging-gates CI) to build without prepare-host-stub.ps1.
+       Explicit -p:SkipHostBridge=true/false always takes precedence. -->
+  <PropertyGroup>
+    <SkipHostBridge Condition="'$(SkipHostBridge)' == '' AND !Exists('$(MSBuildThisFileDirectory)ext\Lidarr\_output\net8.0\Lidarr.dll')">true</SkipHostBridge>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(SkipHostBridge)' == 'true'">
+    <!-- Exclude LidarrNative folder from compilation (must be set before SDK implicit includes)
+         Pattern is relative to each project's directory, not to this props file -->
+    <DefaultItemExcludes>$(DefaultItemExcludes);**/LidarrNative/**;Integration/LidarrNative/**</DefaultItemExcludes>
+  </PropertyGroup>
+
   <!-- Version Management -->
   <PropertyGroup>
     <!-- Read version from VERSION file if it exists -->

build.ps1

@@ -12,6 +12,7 @@ param(
     [switch]$VerboseOutput,
     [switch]$UsePrebuiltAssemblies,
     [string]$LidarrVersion = "2.13.2.4685",
+    [switch]$SkipHostBridge,
     [switch]$Help
 )
 
@@ -120,6 +121,11 @@ if (-not $NoBuild) {
         "-p:TreatWarningsAsErrors=false"
     )
 
+    if ($SkipHostBridge) {
+        $buildParams += "-p:SkipHostBridge=true"
+        Write-Host "⚠️ SkipHostBridge enabled - LidarrNative integration layer excluded" -ForegroundColor Yellow
+    }
+
     if (-not $UsePrebuiltAssemblies -and (Test-Path "ext/Lidarr-source/src/Directory.Build.props")) {
         $buildParams += "-p:LidarrAssemblyVersion=$LidarrVersion"
     }

ext-common-sha.txt

@@ -1 +1 @@
-8b538e7a5ee5f286c08e34261e30c9a1ac57f24e
+8344b04e142281466aa2fc6cb1d916f040e954bf

plugin.json

@@ -10,6 +10,7 @@
   "license": "MIT",
   "tags": ["music", "tidal", "hi-res", "lossless", "oauth"],
   "minHostVersion": "3.0.0.4855",
+  "minimumVersion": "3.0.0.4855",
   "targetFramework": "net8.0",
   "main": "Lidarr.Plugin.Tidalarr.dll",
   "rootNamespace": "Tidalarr"

scripts/ci.ps1

@@ -35,7 +35,8 @@ try {
     dotnet restore "$repoRoot/Tidalarr.sln"
 
     Write-Host "Building plugin (Release configuration)" -ForegroundColor Cyan
-    & "$repoRoot/build.ps1" -Configuration Release -NoBuild:$false
+    # SkipHostBridge excludes LidarrNative files that require Lidarr host assemblies
+    & "$repoRoot/build.ps1" -Configuration Release -NoBuild:$false -SkipHostBridge
 
     # Produce package via shared PluginPack so CLI-scope packaging tests can validate the artifact
     try {
@@ -50,23 +51,41 @@ try {
         if ($IncludeCliTests) { throw }
     }
 
-    Write-Host "Running tests (Release configuration)" -ForegroundColor Cyan
-    # Build tests first since build.ps1 only builds the plugin project
-    # ExcludeHostBridge=true skips HostBridge project that requires full Lidarr assemblies
-    Write-Host "Building test project..." -ForegroundColor Cyan
-    dotnet build "$repoRoot/tests/Tidalarr.Tests/Tidalarr.Tests.csproj" -c Release --no-restore -v minimal `
+    Write-Host "Running tests (Release configuration) via unified runner" -ForegroundColor Cyan
+
+    # Use the unified test runner from Common
+    $unifiedRunner = Join-Path $commonScripts 'test.ps1'
+    if (-not (Test-Path $unifiedRunner)) {
+        throw "Unified test runner not found at: $unifiedRunner"
+    }
+
+    $testProject = Join-Path $repoRoot 'tests/Tidalarr.Tests/Tidalarr.Tests.csproj'
+
+    # Build test project separately with SkipHostBridge since unified runner doesn't pass
+    # Properties to its build step (only to dotnet test)
+    Write-Host "Building test project with SkipHostBridge..." -ForegroundColor Cyan
+    dotnet build $testProject -c Release --no-restore -v minimal `
         -p:RunAnalyzersDuringBuild=false -p:EnableNETAnalyzers=false -p:TreatWarningsAsErrors=false `
-        -p:ExcludeHostBridge=true
+        -p:SkipHostBridge=true -p:ExcludeHostBridge=true
+
+    $testArgs = @{
+        TestProject = $testProject
+        Configuration = 'Release'
+        CI = $true
+        NoBuild = $true  # Already built above with SkipHostBridge
+    }
 
     if ($IncludeCliTests) {
         Write-Host "Including CLI-scope tests (scope=cli)" -ForegroundColor Yellow
-        dotnet test "$repoRoot/Tidalarr.sln" -c Release --no-build
+        # No additional filter - run all tests
     }
     else {
         Write-Host "Excluding CLI-scope tests (scope=cli) for PR/CI runs" -ForegroundColor Yellow
-        dotnet test "$repoRoot/Tidalarr.sln" -c Release --no-build --filter "scope!=cli"
+        $testArgs['AdditionalFilter'] = 'scope!=cli'
     }
 
+    & $unifiedRunner @testArgs
+
     if (-not $SkipPackage) {
         $artifactsDir = Join-Path $repoRoot 'artifacts'
         if (-not (Test-Path $artifactsDir)) {
@@ -77,7 +96,8 @@ try {
         $packageName = "Tidalarr-$($manifest.version).zip"
         $packagePath = Join-Path $artifactsDir $packageName
 
-        $outputDir = Join-Path $repoRoot 'src/Tidalarr/bin/Release/net8.0'
+        # Tidalarr uses OutputPath=bin\ without configuration subdirectory
+        $outputDir = Join-Path $repoRoot 'src/Tidalarr/bin'
         $payload = @(
             Join-Path $outputDir 'Lidarr.Plugin.Tidalarr.dll'
             Join-Path $outputDir 'Lidarr.Plugin.Tidalarr.pdb'

scripts/verify-plugin.ps1

@@ -32,7 +32,7 @@ if (-not $moduleVersionMatch) {
 }
 $moduleVersion = $moduleVersionMatch.Matches[0].Groups['ver'].Value.Trim()
 
-$hostVersionTarget = '2.14.2.4786'
+$hostVersionTarget = '3.0.0.4855'
 $apiMajorPattern = '^1\.x$'
 
 $errors = @()

src/Tidalarr/Tidalarr.csproj

@@ -12,14 +12,14 @@
   </PropertyGroup>
 
   <PropertyGroup>
+    <!-- SkipHostBridge default value -->
     <SkipHostBridge Condition="'$(SkipHostBridge)' == ''">false</SkipHostBridge>
   </PropertyGroup>
 
-  <!-- Hostless/CI builds: exclude Lidarr-native wrappers that require Lidarr host assemblies -->
-  <ItemGroup Condition="'$(SkipHostBridge)' == 'true'">
-    <Compile Remove="Integration\\LidarrNative\\**\\*.cs" />
-    <None Remove="Integration\\LidarrNative\\**\\*" />
-  </ItemGroup>
+  <!-- SkipHostBridge diagnostic: confirm LidarrNative exclusion is working -->
+  <Target Name="SkipHostBridgeDiagnostic" BeforeTargets="CoreCompile" Condition="'$(SkipHostBridge)' == 'true'">
+    <Message Importance="High" Text="[SkipHostBridge] Compile items: @(Compile->Count())" />
+  </Target>
 
   <!-- Dual-path Common wiring: submodule by default; packages when UseInRepoCommon=false -->
   <PropertyGroup>
@@ -82,8 +82,8 @@
     <PackageReference Include="Microsoft.Extensions.Http" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
     <PackageReference Include="System.Text.Json" />
-    <!-- Only use NuGet NLog when Lidarr's copy is unavailable -->
-    <PackageReference Include="NLog" Condition="!Exists('$(LidarrAssembliesPath)\NLog.dll')" ExcludeAssets="runtime;native;contentfiles;analyzers;build;buildtransitive" />
+    <!-- Use NuGet NLog when Lidarr's copy is unavailable OR when SkipHostBridge is enabled -->
+    <PackageReference Include="NLog" Condition="!Exists('$(LidarrAssembliesPath)\NLog.dll') OR '$(SkipHostBridge)' == 'true'" ExcludeAssets="runtime;native;contentfiles;analyzers;build;buildtransitive" />
     <!-- ILRepack for merging dependencies into single plugin DLL.
          ExcludeAssets="build" prevents NuGet's automatic target; we use PluginPackaging.targets instead.
          GeneratePathProperty="true" provides $(PkgILRepack_Lib_MSBuild_Task) for the task import. -->

tests/Tidalarr.Tests/Tidalarr.Tests.csproj

@@ -59,6 +59,8 @@
   <ItemGroup Condition="'$(ExcludeHostBridge)' == 'true'">
     <!-- HostBridge tests require full Lidarr assemblies -->
     <Compile Remove="Unit\HostBridgeMappingTests.cs" />
+    <Compile Remove="Unit\TidalDownloadClientHostSettingsParityTests.cs" />
+    <Compile Remove="Unit\TidalQualityEnumParityTests.cs" />
     <Compile Remove="Unit\TidalProtocolTests.cs" />
     <!-- Lidarr-native download client types require Lidarr.Core -->
     <Compile Remove="Unit\TidalLidarrDownloadClientGuidParsingTests.cs" />
@@ -72,7 +74,8 @@
     <!-- Exclude milestone tests that reference MockTokenStorage -->
     <Compile Remove="Week1MilestoneTests.cs" />
     <Compile Remove="*MilestoneTests.cs" />
-    <!-- Path validation tests updated to match Common's permissive behavior (unblocks Linux CI) -->
+    <!-- Path validation tests have platform-specific expectations that fail on Linux CI -->
+    <Compile Remove="Unit\PathValidationExtensionsTests.cs" />
     <!-- Exclude plugin smoke tests that look for Debug build output -->
     <Compile Remove="PluginSmokeTests.cs" />
     <!-- Exclude compliance tests with false positives -->