feat(phase-14): DoD closure — Common contracts, calibration flag#503
Merged
RicherTunes merged 3 commits intomainfrom Feb 17, 2026
Merged
feat(phase-14): DoD closure — Common contracts, calibration flag#503RicherTunes merged 3 commits intomainfrom
RicherTunes merged 3 commits intomainfrom
Conversation
Replace local ReasonCodes inner class with Common's canonical TriageReasonCodes constants. Use Common's ConfidenceBand enum for classification (output remains lowercase string for API compat). Zero behavior change: all 25 triage/calibration/golden fixture tests pass with identical outputs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add FieldDefinition(43) EnableProviderCalibration setting (default=true) that controls whether per-provider confidence calibration is applied to triage scores. When disabled, the orchestrator passes null for the provider parameter, resulting in raw uncalibrated scores. Add CalibrationDisabled_ReturnsRawScores test verifying the flag behavior: - provider=null yields no CALIBRATION_APPLIED reason code - provider=Ollama yields CALIBRATION_APPLIED + LOW_CALIBRATION_PROVIDER 2415/2415 tests pass (1 known flaky rate limiter test excluded). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 14 (Confidence + Explainability Contracts) Definition of Done closure:
e4586e3to1bacd6dto pick upTriageReasonCodesandConfidenceBandcontracts (PRs chore(common): bump to v1.5.1 #380, fix: make MBID enrichment best-effort (don\u0027t drop recs) #381)ReasonCodesinner class with Common'sTriageReasonCodesconstants; use Common'sConfidenceBandenum for band classification (backward-compatible string output via.ToString().ToLowerInvariant())EnableProviderCalibrationfeature flag (FieldDefinition 43, default=true) — when disabled, orchestrator passesnullfor provider, skipping per-provider confidence calibrationTest plan
RecommendationTriageAdvisorTestspass (including newCalibrationDisabled_ReturnsRawScores)Evidence
🤖 Generated with Claude Code