feat(resilience): wire Brainarr breaker to Common AdvancedCircuitBreaker (WS4.2 PR2)#374
Merged
RicherTunes merged 11 commits intofeat/breaker-registry-seamfrom Jan 17, 2026
Merged
Conversation
…apter # Conflicts: # Brainarr.Tests/Services/Core/ArtistModeMbidsGateTests.cs # Brainarr.Tests/Services/Core/BrainarrOrchestratorSpecificTests.cs # Brainarr.Tests/Services/Core/BrainarrOrchestratorTopUpTests.cs
Root cause: Pre-test cleanup was deleting bin/obj directories, forcing dotnet test to rebuild. This caused parallel MSBuild file locking on Common submodule's .deps.json files. Fix: - Remove `rm -rf Brainarr.Tests/bin Brainarr.Tests/obj` from pre-test cleanup - Add `--no-build` to all dotnet test commands (Linux unit, Linux provider-contract, Windows unit) This ensures tests use pre-built binaries from the Build step, eliminating rebuild-induced file contention. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…rtunes/brainarr into feat/common-breaker-adapter
The backslash followed by trailing spaces on line 136 caused bash to pass extra arguments to MSBuild, triggering MSB1008 "Only one project can be specified" error. Also cleaned up excessive spacing in other test commands. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
RicherTunes
added a commit
that referenced
this pull request
Jan 17, 2026
…ker (WS4.2 PR2) (#374) * feat(resilience): adapt Brainarr breaker to Common AdvancedCircuitBreaker * test(resilience): update DI seam tests for CommonBreakerRegistry * test(orchestrator): inject breaker registry in direct-construction tests * test(orchestrator): inject breaker registry in remaining direct-construction tests * test(orchestrator): add breaker registry injection tripwires * fix(ci): prevent flaky file-locking in dotnet test Root cause: Pre-test cleanup was deleting bin/obj directories, forcing dotnet test to rebuild. This caused parallel MSBuild file locking on Common submodule's .deps.json files. Fix: - Remove `rm -rf Brainarr.Tests/bin Brainarr.Tests/obj` from pre-test cleanup - Add `--no-build` to all dotnet test commands (Linux unit, Linux provider-contract, Windows unit) This ensures tests use pre-built binaries from the Build step, eliminating rebuild-induced file contention. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci: reduce transient dotnet file-lock failures in Test and Coverage * fix(ci): remove trailing whitespace breaking dotnet test command The backslash followed by trailing spaces on line 136 caused bash to pass extra arguments to MSBuild, triggering MSB1008 "Only one project can be specified" error. Also cleaned up excessive spacing in other test commands. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
RicherTunes
added a commit
that referenced
this pull request
Jan 17, 2026
* feat(resilience): wire Brainarr breaker to Common AdvancedCircuitBreaker (WS4.2 PR2) (#374) * feat(resilience): adapt Brainarr breaker to Common AdvancedCircuitBreaker * test(resilience): update DI seam tests for CommonBreakerRegistry * test(orchestrator): inject breaker registry in direct-construction tests * test(orchestrator): inject breaker registry in remaining direct-construction tests * test(orchestrator): add breaker registry injection tripwires * fix(ci): prevent flaky file-locking in dotnet test Root cause: Pre-test cleanup was deleting bin/obj directories, forcing dotnet test to rebuild. This caused parallel MSBuild file locking on Common submodule's .deps.json files. Fix: - Remove `rm -rf Brainarr.Tests/bin Brainarr.Tests/obj` from pre-test cleanup - Add `--no-build` to all dotnet test commands (Linux unit, Linux provider-contract, Windows unit) This ensures tests use pre-built binaries from the Build step, eliminating rebuild-induced file contention. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci: reduce transient dotnet file-lock failures in Test and Coverage * fix(ci): remove trailing whitespace breaking dotnet test command The backslash followed by trailing spaces on line 136 caused bash to pass extra arguments to MSBuild, triggering MSB1008 "Only one project can be specified" error. Also cleaned up excessive spacing in other test commands. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * style: fix formatting in BrainarrCircuitBreakerAdapter --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WS4.2 PR2 (stacked on #373): replace the breaker registry implementation while keeping WS4.1 characterization tests unchanged.
Changes:
Acceptance:
Depends on: