fix: remove quarantine from flaky timing tests#340
Closed
RicherTunes wants to merge 2 commits intomainfrom
Closed
Conversation
- Change TargetFrameworks from net6.0;net8.0 to net8.0 only - Remove net6.0 from nightly CI matrix - Clean up net6.0 LidarrPath fallback logic - Align with lidarr.plugin.common which only supports net8.0 This fixes nightly CI failures caused by TFM incompatibility with the lidarr.plugin.common submodule. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- ConcurrentCache_Should_HandleExpiration: Increase timing margins (500ms expiration, 1500ms wait) for CI stability - RunSyncWithTimeout_WithTimeout_ThrowsTimeout: Use Task.Run to ensure delay starts when measured (1000ms task, 200ms timeout) Both tests were quarantined due to timing precision issues on slow CI runners. The fixes use more generous margins to avoid false negatives. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Owner
Author
|
Stale — superseded by packaging-gates adoption (#397) and ecosystem standardization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two quarantined tests that were failing due to timing precision issues on slow CI runners:
ConcurrentCache_Should_HandleExpiration (SecurityTestSuite.cs)
RunSyncWithTimeout_WithTimeout_ThrowsTimeout (SafeAsyncHelperTests.cs)
Task.Delay(200).ContinueWith()with 100ms timeoutTask.Runto ensure timing starts when measured (1000ms task, 200ms timeout)Root Cause
Both tests were flaky because:
Task.Delaytiming precision varies across systemsTest plan
🤖 Generated with Claude Code