fix: remove analyzer-disabling AdditionalProperties that caused duplicate builds#339
Closed
RicherTunes wants to merge 1 commit intomainfrom
Closed
fix: remove analyzer-disabling AdditionalProperties that caused duplicate builds#339RicherTunes wants to merge 1 commit intomainfrom
RicherTunes wants to merge 1 commit intomainfrom
Conversation
…cate builds The AdditionalProperties on the Common ProjectReference were disabling analyzers (RunAnalyzersDuringBuild, EnableNETAnalyzers) to suppress PublicAPI warnings. However, this caused MSBuild to treat the Common project as a different build configuration than when built standalone, leading to duplicate parallel builds and file locking race conditions: CSC error CS2012: Cannot open 'dll' for writing Fix: Keep only GeneratePackageOnBuild=false (which is legitimately needed to prevent Common from generating a NuGet package during plugin builds). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Owner
Author
|
Stale — superseded by packaging-gates adoption (#397) and ecosystem standardization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes analyzer-disabling properties from the
AdditionalPropertieson the Common ProjectReference that were causing MSBuild to treat Common as a different build configuration, leading to duplicate parallel builds and file locking race conditions on Windows CI:Changes
Brainarr.Plugin/Brainarr.Plugin.csproj
Before:
After:
Kept
GeneratePackageOnBuild=falsewhich is legitimately needed to prevent Common from generating a NuGet package during plugin builds.Related
🤖 Generated with Claude Code