fix(ci): update to net8.0 only for Lidarr 3.x compatibility#338
Closed
RicherTunes wants to merge 1 commit intomainfrom
Closed
fix(ci): update to net8.0 only for Lidarr 3.x compatibility#338RicherTunes wants to merge 1 commit intomainfrom
RicherTunes wants to merge 1 commit intomainfrom
Conversation
- Change TargetFrameworks from net6.0;net8.0 to net8.0 only - Remove net6.0 from nightly CI matrix - Clean up net6.0 LidarrPath fallback logic - Align with lidarr.plugin.common which only supports net8.0 This fixes nightly CI failures caused by TFM incompatibility with the lidarr.plugin.common submodule. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Owner
Author
|
Stale — superseded by packaging-gates adoption (#397) and ecosystem standardization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net6.0;net8.0tonet8.0only6.0.xfrom nightly CI matrixProblem
Nightly CI was failing with:
The lidarr.plugin.common submodule only targets net8.0, causing restore failures when brainarr tried to build for net6.0.
Solution
Align brainarr with Lidarr 3.x (mainline) which requires .NET 8.0. Remove all net6.0 targeting and fallback paths.
Test plan
dotnet restoresucceeds🤖 Generated with Claude Code