style(pre-commit): global trim trailing whitespace (cache + tests)#165
style(pre-commit): global trim trailing whitespace (cache + tests)#165RicherTunes merged 17 commits intomainfrom
Conversation
… to restore compilation
…; tolerate errors
…rtion (factory call still constrained to 1)
…e to satisfy pre-commit
…/CacheResult/CacheMetrics sections)
…Cache.cs (restore base formatting)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| /// <summary> | ||
|
|
||
| /// Tries to get a value from the cache. | ||
|
|
||
| /// </summary> | ||
|
|
||
| public async Task<bool> TryGetAsync(string key, out List<ImportListItemInfo> value) | ||
|
|
||
| { | ||
|
|
||
| var result = await GetAsync(key); | ||
|
|
||
| value = result.Value; | ||
|
|
||
| return result.Found; |
There was a problem hiding this comment.
[P0] Make TryGetAsync compile-safe
The new TryGetAsync signature is declared as public async Task<bool> TryGetAsync(string key, out List<ImportListItemInfo> value). C# forbids async methods from having out (or ref) parameters, so this file will no longer compile. Consider returning the value inside the Task result (e.g. Task<CacheResult<T>>) rather than using an out parameter.
Useful? React with 👍 / 👎.
Includes: - PR #165: disc-aware naming, extension normalization - PR #166: maxConcurrentTracks for bounded parallelism 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Includes: - PR #165: disc-aware naming, extension normalization - PR #166: maxConcurrentTracks for bounded parallelism 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Includes: - PR #165: disc-aware naming, extension normalization - PR #166: maxConcurrentTracks for bounded parallelism 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 participant
Removes trailing spaces across EnhancedRecommendationCache.cs and two test files to satisfy pre-commit hooks.