Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7532328.
I discovered that this was causing problems after attempting to update rollup-plugin-commonjs to use the latest of all its dependencies, including magic-string. Updating from v0.10.0 to v0.11.1 produced the following error:
I noticed that the source map differed between the different versions of magic-string:
It appears the source map in v0.11.1 is a truncated version of the other one. I determined that this commit was the bad one by using
git bisect
andnpm link
to run therollup-plugin-commonjs
tests with each revision, usinggit bisect skip
on a few commits in magic-string that failed to pass its own tests. After reverting the bad commit on top of the current master the tests for rollup-plugin-commonjs began to work again. I don't have enough context on magic-string to fix the underlying cause, but you probably do, @Rich-Harris. Let me know if you need more information!