more bitwise trickery #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM I thought the V8 engine would make the same optimizations for powers of 2, but I see that this PR is around 0.3 seconds faster for 100MB of input on node 12, and around 0.75 seconds faster on older JS engines. In the original bit set proposal I was trying to determine what the maximum number of bits that could be used in integer bit operations on JS engines. Since a JS double (IEEE 754) has a 53 bit significand I was hoping it would be higher than 32. Not the case. |
mourner
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this comment from @Th0rN13. According to my microbenchmarks, this is indeed a (probably very modest!) performance win