Correct SourceMap/Options TypeScript definitions #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceMapOptions does not include most of SourceMap's keys. In addition, SourceMap's constructor receives a SourceMap type, for initializing the instance.
this way TypeScript enforces that its not used as a constructor in user code.
|
Hey @Rich-Harris, can you check this out? :) |
|
Sorry, just saw this — thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceMapOptionsdoes not include most ofSourceMap's keys.sourcewas also missing and added.In addition,
SourceMapis now an interface so that TypeScript won't let user code to use it withnew(it's not being exported from main)