Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not iterate over prototype properties of reducers #80

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

danielroe
Copy link
Contributor

@danielroe danielroe commented Aug 30, 2024

reproduction: https://stackblitz.com/edit/stackblitz-starters-iiewc5

import { stringify } from 'devalue';

let a = {};
a.__proto__.appConfigEnabled = 1;

stringify({}, {});
// Error: fn is not a function

@Rich-Harris
Copy link
Owner

thank you — looks like this causes tests to fail, any ideas?

@danielroe
Copy link
Contributor Author

apologies for that!

@Rich-Harris
Copy link
Owner

ah, I see now — thanks!

@Rich-Harris Rich-Harris merged commit ed122c6 into Rich-Harris:main Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants