test(steering): update stale fixtures for post-#217/#219 runner state - #225
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 40 pre-existing CPU test failures on feat/dynamic-steering. Production code merged in #217 and #219 grew runner/manager state that the duck-typed test fixtures never gained, so the tests fail on fixture AttributeErrors, not product behavior:
_MixinHost(test_steering_dynamic_override.py): missing_req_override_source(Declarative per-request steering gates (when × scope × apply) #219 precedence tracking) — 17 failures._make_gluehost (test_gpu_v2_steering_glue.py): same missing attribute via the inherited scale/monitor applies — 11 failures._FakeManager(test_gpu_v2_steering_glue.py): missinghas_row_monitor(feat(steering): per-request probe table (true per-request in-graph monitor) #217 short-circuit predicate) — 2 failures._RunnerStub(test_sync_steering_integration.py): missing_sync_steering_gates(Declarative per-request steering gates (when × scope × apply) #219 step-view field) — 9 failures._FakeEvent(test_sync_steering_integration.py): missing the non-blockingquery()the deferred CUDA-event metric now guards on — 1 failure.Each addition mirrors the production init exactly; no test logic or assertions changed. The three suites go 40 failed / 40 passed → 80 passed.
Expected sibling-PR conflict: #224 adds the identical
_req_override_source = {}line to_make_glue(trivial resolution, keep one copy).