refactor(capture): rename hook point post_mlp -> post_block - #198
Merged
Conversation
This was referenced Jun 24, 2026
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the activation-capture / steering hook point
post_mlp->post_blockproject-wide (136 files): theHookNameLiteral, the_HOOK_NAME_TO_IDmap,SteeringHookPoint.POST_MLP->POST_BLOCK(value"post_block") and its table-attr names, every validator (filesystem + graphsafe + steering protocols), the plan/manager/runner plumbing, all model files that register the hook, docs, examples, rust test fixtures, and tests.Aligns the hook naming with PR #174 (which bundles this rename with other capture work); this PR is the rename portion in isolation.
Why
post_blockmore accurately names the residual-stream tap (after the full decoder block) and matches the naming used in #174's capture work, so the two don't diverge on the hook vocabulary.Breaking change
This is a hard rename with no
post_mlpalias. Any config/request using the old name must switch topost_block: capturehooksdicts,--capture-graphsafe-key <layer>:post_mlp, filesystemglobal_hooks, per-requestSamplingParams.capturespecs, steering module JSON ({"vectors": {"post_mlp": ...}}), and the OpenAI/serve steering APIs.Note
The model RMSNorm attributes
post_mlp_norm/post_mlp_layernormare intentionally left unchanged — they are layernorm module/weight names unrelated to the capture/steering hook, and renaming them would risk breaking checkpoint weight-name matching.Sibling PRs
Touches
scheduler.py/manager.py, so it will conflict with thecapture_waitPR and the already-merged capture PRs — resolve additively at merge.