Fix hf iclass/15693 sniff trace timings.#2010
Merged
iceman1001 merged 3 commits intoRfidResearchGroup:masterfrom Jun 15, 2023
Merged
Fix hf iclass/15693 sniff trace timings.#2010iceman1001 merged 3 commits intoRfidResearchGroup:masterfrom
iceman1001 merged 3 commits intoRfidResearchGroup:masterfrom
Conversation
Previously reader durations would be reported to be twice as long in the trace vs reality, and as a result the start time would be earlier than it should have been as well. Also fixes a minor sniff trace timing with card dual subcarrier responses.
Signed-off-by: Iceman <iceman@iuse.se>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously reader durations would be reported to be twice as long in the trace vs reality, and as a result the start time would be earlier than it should have been as well.
Also fixes a minor sniff trace timing with card dual subcarrier responses.
Cleaned up some duplicated code and added a bunch of comments to hopefully explain how some of the magic numbers were calculated.