Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fossilization buttons' positioning account for screen distortion #5954

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dligr
Copy link
Member

@dligr dligr commented Feb 24, 2025

Brief Description of What This PR Does

Applies chromatic abberation (barrel distortion) to fossilization buttons' positions, placing them where microbes visually are.

This requires an inverse function. The true inverse function for barrel distortion would be way too complex (something like this), so this PR uses an approximation, though its inaccuracy seems almost negligible. It breaks when the given position is outside of the screen, but it's fixable with clamping.

Related Issues

Fossilization buttons being too far from their microbes

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@dligr dligr added the review label Feb 24, 2025
@dligr dligr added this to the Release 0.8.2 milestone Feb 24, 2025
@dligr dligr requested review from a team February 24, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant