Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermosynthesis full implementation #5866

Merged
merged 24 commits into from
Feb 6, 2025
Merged

Conversation

hhyyrylainen
Copy link
Member

@hhyyrylainen hhyyrylainen commented Jan 31, 2025

Brief Description of What This PR Does
Full implementation of thermosynthesis where temperature change is required to produce energy

Related Issues

closes #3496
Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.1 milestone Jan 31, 2025
@hhyyrylainen hhyyrylainen marked this pull request as ready for review February 6, 2025 13:18
@hhyyrylainen
Copy link
Member Author

This needs a follow up balancing effort, but the main implementation is now done.

@hhyyrylainen hhyyrylainen merged commit e6a9dc5 into master Feb 6, 2025
3 of 4 checks passed
@hhyyrylainen hhyyrylainen deleted the thermosynthesis_full branch February 6, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement the remaining thermoplast features
1 participant