Clear endosymbiosis when entering multicellular #5864
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhyyrylainen
requested changes
Jan 31, 2025
| var endosymbiosis = GameWorld.PlayerSpecies.Endosymbiosis; | ||
|
|
||
| if (endosymbiosis.StartedEndosymbiosis != null) | ||
| endosymbiosis.CancelEndosymbiosisTarget((int)endosymbiosis.StartedEndosymbiosis.Species.ID); |
There was a problem hiding this comment.
I think it would be better to write a new method in EndosymbiosisData called something like CancelAllTargets (or something similar) that would just always be called here, and that would then clear up any endoymbiosis targets. That way the code here will keep working if ever it is added support for to have multiple ongoing endosymbiosis processes at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description of What This PR Does
This PR does some stuff...
Related Issues
Closes #5844
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.