Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed sulfur chunks from abyssopelagic and coastal patches #5754

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

hhyyrylainen
Copy link
Member

Brief Description of What This PR Does

Adjusts sulfur availability

Related Issues

https://discord.com/channels/464846402732687391/464846975406440449/1317211313189027880

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.0 milestone Dec 16, 2024
@hhyyrylainen hhyyrylainen requested review from HexapodPhilosopher and a team December 16, 2024 13:37
@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

@HexapodPhilosopher
Copy link
Contributor

This is fine. I've now added the same thing to my PR, so this is obsolete when that gets added.

@hhyyrylainen
Copy link
Member Author

I'm merging this first as your PR is big and I want theory opinion whether it is fine.

@hhyyrylainen hhyyrylainen merged commit b51e85d into master Dec 17, 2024
4 checks passed
@hhyyrylainen hhyyrylainen deleted the sulfur_chunk_adjustment branch December 17, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants