Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI for controlling organelle split order #5688

Merged
merged 24 commits into from
Nov 20, 2024

Conversation

hhyyrylainen
Copy link
Member

@hhyyrylainen hhyyrylainen commented Nov 15, 2024

Brief Description of What This PR Does

Adds a new GUI tab in the microbe editor to pick organelle growth order

Related Issues

closes #1622

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.0 milestone Nov 15, 2024
@hhyyrylainen hhyyrylainen marked this pull request as ready for review November 19, 2024 14:19
@hhyyrylainen hhyyrylainen requested review from a team November 19, 2024 14:19
@hhyyrylainen
Copy link
Member Author

I found a bug when testing but I'm not going to fix this in this PR: #5696

Copy link
Contributor

@CI09 CI09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playtest works

Copy link
Member

@dligr dligr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this works in-game. Save-loading doesn't reset the split order. The only unexpected behavior I noticed is that it isn't possible to undo changes to the order with the editor's undoing (unless this is intended).
The code seems to be fine.

@hhyyrylainen
Copy link
Member Author

it isn't possible to undo changes to the order with the editor's undoing (unless this is intended).

I didn't make it into an action that would go into the undo/redo system as that would have complicated things a lot. It is in fact implemented separately from the action system and the results are only applied when exiting the editor as I thought that would be a pretty good way to ensure that mixed edits and growth order changes work at least reasonably well.

@hhyyrylainen hhyyrylainen merged commit c6f439b into master Nov 20, 2024
4 checks passed
@hhyyrylainen hhyyrylainen deleted the 1622_organelle_split_order branch November 20, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a way for the player to control organelle split (growth) order
3 participants