-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GUI for controlling organelle split order #5688
Conversation
but they don't do anything yet
I found a bug when testing but I'm not going to fix this in this PR: #5696 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playtest works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this works in-game. Save-loading doesn't reset the split order. The only unexpected behavior I noticed is that it isn't possible to undo changes to the order with the editor's undoing (unless this is intended).
The code seems to be fine.
I didn't make it into an action that would go into the undo/redo system as that would have complicated things a lot. It is in fact implemented separately from the action system and the results are only applied when exiting the editor as I thought that would be a pretty good way to ensure that mixed edits and growth order changes work at least reasonably well. |
Brief Description of What This PR Does
Adds a new GUI tab in the microbe editor to pick organelle growth order
Related Issues
closes #1622
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.