Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for transition before loading #3616

Merged

Conversation

DrRadek
Copy link
Contributor

@DrRadek DrRadek commented Jul 28, 2022

Brief Description of What This PR Does

Waits for transition to finish before loading (Suggested by hhyyrylainen).
It's currently not possible to implement multi-threaded loading without major slowdown due to Godot 3 limitations (see godotengine/godot#36793).

Related Issues

closes #3566

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.5.10 milestone Jul 28, 2022
@hhyyrylainen
Copy link
Member

Thanks for the link about the threading thing, certainly very interesting. I did already know that Godot 4.0 makes background resource loading (more) possible.

I edited your PR description to mark this as actually not closing that other issue (which I updated with a new label and comment), but the more recent too long black screen issue #3566

@DrRadek DrRadek requested a review from hhyyrylainen July 28, 2022 14:55
@hhyyrylainen hhyyrylainen requested review from a team July 28, 2022 17:43
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine now and seems to work in game.

@hhyyrylainen hhyyrylainen merged commit cfec71a into Revolutionary-Games:master Jul 31, 2022
@DrRadek DrRadek deleted the loading_animation_fix branch July 31, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

A black screen is now shown much longer than the loading screen when loading a save
2 participants