1541 - Fixing lack of iron chunks in cave #2389
Conversation
| to spawn the given entity. | ||
| to spawn the given entity. Furthermore, each attempt gives a spawn chance | ||
| for each spawner (up to their type limit) to still favor diversity, | ||
| instead of one spawner taking up all the free spawning slots. |
There was a problem hiding this comment.
Was the issue that the spawners were making so much of one thing that they were reaching the maximum of living entities, which kept iron from spawning in the cave? From testing this change clearly works, but I don't understand why.
There was a problem hiding this comment.
That could certainly be a thing. For a while now, I've wanted per entity spawn caps (that are more reasonable, for example I think if the 1000 entity limit fills up with cells the game will lag, a lot).
There was a problem hiding this comment.
That was not even the total cap, but the per-frame cap (toxyns were taking all slots (compounds would still go first as they spawned, I guess), that's why decreasing their density led to iron spawning)
There was a problem hiding this comment.
Per-frame? As in the spawner has been adding 500 toxyns per frame? I certainly haven't observed that in game...
There was a problem hiding this comment.
No, the per-frame limit is yet another thing, and is much smaller (2, I think). So at each frame, 2 entities would be spawned if that did not go over total cap aswell (which makes sense, both to not have long spawning frame and to be able to spawn new things to adapt - although it could be raised shortly after new patch spawn).
Yet, given that toxins had such a high spawning rate, they always spawned up to the frame spawn limit (they roughly had ~100 chances out of 500 (max cap) so 20% chances, for 50 spawn trials or so). And thus, spawners later in the list were not tested in this frame, and the list would be reset at the next frame.
I guess that another fix could have been to save the remaining spawner list for next frame to cycle it all.
There was a problem hiding this comment.
For a while now, I've wanted per entity spawn caps
Capping toxins to 100, and having a separate cap for iron and marine snow chunks, is what I meant in my comment. This doesn't have anything to do with per-frame caps, which also probably could be problematic if the toxins take up all the per-frame spawns... this is addressed by: #2138 (which is an incomplete PR to change the spawn system) which uses a round robin approach to spawn from a randomized item list.
There was a problem hiding this comment.
Indeed a per-entity cap is a fully independant question, related to the total cap which is not the reason for the issues fixed here (but I agree this could prove useful overall).
This PR was really about identifying their cause and fixing them within the current system as they really harm game experience in patches.
There was a problem hiding this comment.
I'm also going to take a look at the incomplete spawn change PR though, see if I feel like taking it up.
Co-authored-by: adQuid <[email protected]>
| @@ -68,9 +68,12 @@ public class SpawnSystem | |||
| /// </summary> | |||
| private int estimateEntityCount; | |||
|
|
|||
| private Dictionary<Spawner, int> attemptsPerSpawnType; | |||
There was a problem hiding this comment.
wouldn't it be better to have the attempts counter in the Spawner class itself? Or is there somthing prohibiting this I don't see?
There was a problem hiding this comment.
No, you are right, the spawner-dependent part could be stored in Spawner indeed for memory saving.
However, given that I think I'm finally succeeding with a more efficient rework with PR #2397 (which also solves this spawn order thing), I think I'll discontinue this one for a bit, and only resume if the other PR actually does not work / takes longer and a hotfix is needed.
|
So this PR will be superceded by #2397 if that gets done first. |
Brief Description of What This PR Does
This PR adress the issue of lacking iron in the cave, by two fixes:
Related Issues
Resolves #1541 and resolves #1626 and resolves #1777 .
Progress Checklist
Note: before starting this checklist the issue should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author.