Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for file:/// style urls for MRAN location #218

Closed
wants to merge 1 commit into from
Closed

Added support for file:/// style urls for MRAN location #218

wants to merge 1 commit into from

Conversation

mungojam
Copy link
Contributor

@mungojam mungojam commented Jun 7, 2016

No description provided.

@mungojam mungojam mentioned this pull request Jun 7, 2016
Closed
@andrie
Copy link
Contributor

andrie commented Oct 17, 2016

This is a fix for #217

@andrie andrie added this to the v0.3.17 milestone Oct 26, 2016
@andrie
Copy link
Contributor

andrie commented Oct 26, 2016

This looks good. The code needs a little bit of documentation and unit tests. I am working on these.

Many thanks.

andrie added a commit that referenced this pull request Oct 26, 2016
@andrie
Merge pull request #218 and add unit tests.
1d3e948
@andrie
Copy link
Contributor

andrie commented Oct 26, 2016

Added unit tests with commit 1d3e948

@andrie andrie closed this Oct 26, 2016
andrie added a commit that referenced this pull request Oct 26, 2016
@andrie
Merge branch 'dev'
a819942 
* dev:
  Write log file data to ~/.checkpoint/checkpoint_log.csv #212
  Merge pull request #218 and add unit tests.
  Update mranUrl.R
  Initial commit to write log data to a file ~/.checkpoint/.checkpoint_log.csv #212
@nuest nuest mentioned this pull request Dec 7, 2016
Open
@mungojam mungojam deleted the mungojam-issue217 branch October 7, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement pull request
Projects
None yet
Milestone
v0.3.17
Development

Successfully merging this pull request may close these issues.
2 participants
@mungojam @andrie