Skip to content

Adds docs to StoreProduct#521

Merged
vegaro merged 2 commits intomainfrom
better-storeproduct-docs
Oct 30, 2024
Merged

Adds docs to StoreProduct#521
vegaro merged 2 commits intomainfrom
better-storeproduct-docs

Conversation

@vegaro
Copy link
Member

@vegaro vegaro commented Oct 29, 2024

With RevenueCat/purchases-hybrid-common#952 I realized that the docs were missing

@vegaro vegaro added the pr:other Changes to our CI configuration files and scripts label Oct 29, 2024
return $"{nameof(Identifier)}: {Identifier}\n" +
$"{nameof(ServerDescription)}: {ServerDescription}\n" +
$"{nameof(AvailablePackages)}: {AvailablePackages}\n" +
$"{nameof(AvailablePackages)}: {string.Join(", ", AvailablePackages)}\n" +
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just printing that it was an array, not printing the content

/// Otherwise, it contains the introductory price of the product if the user is eligible for it.
/// This will be null for non-subscription products.
/// </summary>
/// <returns></returns>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docs will make sense after RevenueCat/purchases-hybrid-common#952

@vegaro vegaro marked this pull request as ready for review October 29, 2024 19:01
@vegaro vegaro requested review from a team and MarkVillacampa and removed request for a team and MarkVillacampa October 29, 2024 19:02
@vegaro vegaro merged commit 12c443c into main Oct 30, 2024
@vegaro vegaro deleted the better-storeproduct-docs branch October 30, 2024 06:53
kaushikpaperboat added a commit to Kiddopia/purchases-unity that referenced this pull request Oct 30, 2024
* commit '58990de155c37f42d662c33f2eff9b3d7984b3c6': (26 commits)
  Update VERSIONS.md
  Version bump for 7.3.0
  Adds docs to `StoreProduct` (RevenueCat#521)
  Fix metadata values types (RevenueCat#523)
  [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.7.0 (RevenueCat#524)
  support displaying deferred win-back StoreKit messages
  Bump rexml from 3.3.8 to 3.3.9 (RevenueCat#520)
  Bump danger from 9.5.0 to 9.5.1 (RevenueCat#518)
  Bump fastlane from 2.224.0 to 2.225.0 (RevenueCat#517)
  [AUTOMATIC] Release/7.2.1 (RevenueCat#514)
  [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.5.0 (RevenueCat#513)
  Bump fastlane from 2.223.1 to 2.224.0 (RevenueCat#512)
  [AUTOMATIC] Release/7.2.0 (RevenueCat#511)
  Add visionOS support (RevenueCat#471)
  Bump fastlane from 2.222.0 to 2.223.1 (RevenueCat#509)
  [AUTOMATIC] Release/7.1.2 (RevenueCat#508)
  [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.3.0 (RevenueCat#507)
  [AUTOMATIC] Release/7.1.1 (RevenueCat#506)
  Bump fastlane-plugin-revenuecat_internal from 5140dbc to 55a0455 (RevenueCat#505)
  update allowSharingAppStoreAccount deprecation message
  ...

# Conflicts:
#	.version
#	CHANGELOG.latest.md
#	CHANGELOG.md
#	RevenueCat/Plugins/Android/PurchasesWrapper.java
#	RevenueCat/Plugins/iOS/PurchasesUnityHelper.m
#	RevenueCat/package.json
#	VERSIONS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:other Changes to our CI configuration files and scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants