-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dockerize the app #105
Conversation
* change loop config to false, or container will run forever * support latest node on latest alpine, smallest size possible * fix format issue using eslint (default config) * added @babel/core since this is needed for eslint-parser
Build, lint, test on Windows/Linux with Node 12, 14, 16
* fix calling eslint via npx * remove windows & node 14
I suggest adding a version: '3.4'
services:
epicgamesfreebiesclaimer:
image: epicgamesfreebiesclaimer
build:
context: .
dockerfile: ./Dockerfile
volumes:
- ./device_auths.json:/app/device_auths.json:ro
restart: unless-stopped and keeping Also optionally if @Revadike would like, add the workflow to build the image using gh-actions and use github container registry to host it in this repo. Reference that image in |
I am not using GitHub actions. GitHub will definitely ban this repo again if they got abused, so I rather stay away from it. |
Thanks for the suggestion @marchenm. I'm not a fan of keeping the loop but that looks good, let's get the suggestion from @Revadike. @Revadike |
Since I'm not testing this, I have to rely on third party reviewers. If they say its ok, I will merge it. |
Also, could you explain why should I merge this PR and not the other docker PR? |
This PR uses a newer version of node, works with the latest version of the codebase, and results in a smaller image size. It also doesn't add any additional scripts to the docker image. |
Alright, I will likely add this with the next update. Thanks everyone contributing to and reviewing this PR! |
Hi,
I love your repo very much, it's a very good way to grab the freebie without any browser involved. It is much less flaky than browser way!
Also, I see that #33 has a "help wanted" tag, so here I help. This PR has no function change, only to implement a new way to use the package. Very minimal size, only 12MB bigger than
node:16-alpine3.13
image.I also improve some other stuff:
I've written a Guide on how to use the Docker image (and how to dev).
Any feedback will be helpful 🚀