ugly code - #10
Closed
ReubenBond wants to merge 1 commit into
Closed
ugly code#10ReubenBond wants to merge 1 commit into
ReubenBond wants to merge 1 commit into
Conversation
Owner
Author
|
/format |
1 similar comment
Owner
Author
|
/format |
ReubenBond
force-pushed
the
tmp/rebond-bad-formatting/1
branch
from
July 24, 2025 17:45
1aa22ff to
8deb9ab
Compare
ReubenBond
added a commit
that referenced
this pull request
Aug 2, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 2, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 10, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 12, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 18, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 21, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 22, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 23, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 24, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 24, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 25, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 26, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Aug 28, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Sep 3, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Sep 3, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Sep 3, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Sep 3, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Sep 4, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Sep 7, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
ReubenBond
added a commit
that referenced
this pull request
Sep 7, 2026
…hing Implements Feature #10 from feature-list.json. This commit introduces RouteKeyHandler, an abstract base class that simplifies implementing handlers that respond only to messages with a specific route key using exact string matching. Key Features: - Abstract base class implementing IInboxHandler - Constructor validates route key (non-null, non-empty, non-whitespace) - CanHandle performs case-sensitive exact string comparison - Protected RouteKey property for derived class access - Abstract HandleAsync forces derived implementation - Comprehensive XML documentation with usage examples Test Coverage: - 13 new BVT tests covering all RouteKeyHandler functionality - Tests for exact matching, null handling, case-sensitivity - Tests for validation, special characters, cancellation - All tests pass on both net8.0 and net10.0 Build Status: - Clean build with 0 warnings, 0 errors - All 328 Orleans.Journaling BVT tests passing Files Added: - src/Orleans.Journaling/Messaging/RouteKeyHandler.cs - test/Orleans.Journaling.Tests/RouteKeyHandlerTests.cs Files Modified: - research/feature-list.json (marked Feature #10 as passing) - research/progress.txt (added feature summary)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context