Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSB-265: Introduce upgrade list and db backup before upgrade #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abdulazizali77
Copy link
Contributor

No description provided.

@abdulazizali77 abdulazizali77 changed the title MSB-265: Introduce upgrade list and db backup before upgrade WIP MSB-265: Introduce upgrade list and db backup before upgrade Dec 19, 2017
@abdulazizali77 abdulazizali77 changed the title WIP MSB-265: Introduce upgrade list and db backup before upgrade MSB-265: Introduce upgrade list and db backup before upgrade Dec 20, 2017
@abdulazizali77
Copy link
Contributor Author

@vetss Sergey please have a look
-I have not added the new DB options to shell executor as i think it shouldnt be modifiable during runtime. What do you think?
-Do you think we should populate the dbLogin dbPass in UssdProperties.xml or should we fetch it from the *-ds.xml? (not sure how to do that yet)

@vetss
Copy link
Contributor

vetss commented Dec 28, 2017

Hello @abdulazizali77

I checked your PR. Comments:

  • no manaual / CLI / GUI updates (let us do it further when all other staff became working)
  • when adding of new filelds into xml config files we may not add them into the end of the file (config files from old versions will not be loadable, this is an xml lib usage issue). So we need to add into a middle of the file
  • have you tested your code locally ? I mean prepare some database structure and run a server and check how will it make backups or database structure updates ? I have some doubts for example for module "checkUpgradePath()" does not push value "src" back to upper level.
  • you use a specific mysql staff. Let's test what will happen in case of another database, may be it will bring us some malfunctions. Ideally if we manage to reuse of staff that if universal for any database. For example "SELECT TABLE_NAME FROM INFORMATION_SCHEMA.COLUMNS" may be replaced by a "select from ***" and try to catch an Exception. All of this demands carefuly testing. You may add a unit test by the way.

I have not added the new DB options to shell executor as i think it shouldnt be modifiable during runtime. What do you think?

Such options may be modifyable during runtime for usage in the next start. We need to mention it in the manual.

Do you think we should populate the dbLogin dbPass in UssdProperties.xml or should we fetch it from the *-ds.xml? (not sure how to do that yet)

Login and pass - we can include it into an xml file. "*-ds.xml" is also an option but it may take efforts, not sure this is really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants