-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for processing messages after MProc drop/reject. #261
base: master
Are you sure you want to change the base?
Conversation
Hello @mniemiec I have checked your update but I did not get which issue it tries to fix.
Is it a behavior change you want to achieve ? If yes, can you explain WHY do we need such change ? |
Hi Sergey, in case of message rejection by MProc Rule we had NullPointerException because smss: FastList smss = mProcResult.getMessageList(); was null. The NPE was thrown when it comes to iterate with: for (FastList.Node n = smss.head(), end = smss.tail(); (n = n.getNext()) != end;) { So I suggest first to check if we are rejected/dropped. Then if not we can assume the smss is filled in. Regards, |
Hello Adam, @ovoo-unif
ok, this is a good point and I prepared a separate commit to avoid of this case. Thanks for bug reporting. This is a refecrense to commit : Can we discuss your PR and my questions (for your PR): can you please comment more what do you mean "We do not attempt to process messages successfuly if there was MProc rule reject or drop.". Which behaviour do you expect ?
|
We do not attempt to process messages successfuly if there was MProc rule reject or drop.