Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: dropping python2 support #369

Closed
yarikoptic opened this issue Feb 8, 2019 · 2 comments
Closed

RF: dropping python2 support #369

yarikoptic opened this issue Feb 8, 2019 · 2 comments
Labels
needs-input Discussion is ongoing, more feedback/input is needed to make a decision on how to proceed

Comments

@yarikoptic
Copy link
Member

The verdict was made to drop python2 support in reproman since anyways it is mostly a command line tool anyways, and we interact with the remote sessions from local environment so do not care about what version of python is on remote end. So, possibly to take advantage of python3-only features we are dropping python2 now (well, as soon as PR comes in ripping all compatibility shimming). I think code in PRs shouldn't conflict much if at all.
The question remaining - what minimal version of python3 we would like to support? I guess it would depend on what new features we would like to make use of, and for that we better familiarize us with what is available across python3 versions. Please chime in posting your favorite (I can only google up some) summaries for "what's new in python 3.x"
@yarikoptic yarikoptic added the needs-input Discussion is ongoing, more feedback/input is needed to make a decision on how to proceed label Feb 8, 2019
@kyleam
Copy link
Contributor

kyleam commented Feb 8, 2019 •
edited by yarikoptic
Loading

Woohoo :>

The question remaining - what minimal version of python3 we would like to support? I guess it would depend on what new features we would like to make use of

I don't feel strongly about what the minimal minor version is. I suppose the highest we should consider is probably what's in Debian Stable? That's 3.5.

and for that we better familiarize us with what is available across python3 versions. Please chime in posting your favorite (I can only google up some) summaries for "what's new in python 3.x"

Well, I'm mostly just googling too :]

The boring things I'd want are all there before 3.4:

  • tuple unpacking (3.0),
  • keyword-only arguments (3.0) (def xxx(..., *, ...))
  • yield from (3.3).

Some notable modules/features to consider in my view:

  • pathlib (3.4),
  • concurrent.futures (3.2),
  • type hints (3.5),
  • and asyncio (3.4).

So, I dunno. 3.4?

@kyleam kyleam mentioned this issue Feb 14, 2019
Merged
@yarikoptic
Copy link
Member Author

yarikoptic commented Feb 21, 2019 •
edited
Loading

  • explicit string format f"..." (3.6)

@yarikoptic yarikoptic mentioned this issue Mar 1, 2019
Closed
kyleam added a commit to kyleam/niceman that referenced this issue Feb 20, 2020
@kyleam
MNT: Bump Python dependency to 3.5
c125a9a 
The latest PyYAML release (5.3) has dropped support for Python 3.4,
putting our 3.4 build on Travis into a failing state [0].  When we
transitioned to Python 3 only, we didn't have a strong reason for
choosing 3.4 as our floor (discussed in ReproNimgh-369), so let's just bump it
to 3.5.

[0]: https://travis-ci.org/ReproNim/reproman/jobs/653138599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-input Discussion is ongoing, more feedback/input is needed to make a decision on how to proceed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yarikoptic @kyleam