Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3digit comma values evaluated as 1000s #357

Closed
motsumipower opened this issue Jun 19, 2023 · 7 comments
Closed

3digit comma values evaluated as 1000s #357

motsumipower opened this issue Jun 19, 2023 · 7 comments
Assignees
Labels
enhancement Feature request
Milestone

Comments

@motsumipower
Copy link

CSV data is :

Current,2023-06-19 14:57:32.418625,0.619
Current,2023-06-19 14:57:34.951757,0.606
Current,2023-06-19 14:57:37.637850,0.606
Current,2023-06-19 14:57:40.307085,0.636
Current,2023-06-19 14:57:42.857076,0.582
Current,2023-06-19 14:57:45.479023,0.601
Current,2023-06-19 14:57:48.088373,0.583
Current,2023-06-19 14:57:50.722451,0.607
Current,2023-06-19 14:57:53.399883,0.673
Current,2023-06-19 14:57:56.053952,0.62
Current,2023-06-19 14:57:58.608875,0.598

it becomes

Current 2023-06-19 14:57:34 606
Current 2023-06-19 14:57:37 606
Current 2023-06-19 14:57:40 636
Current 2023-06-19 14:57:42 582
Current 2023-06-19 14:57:45 601
Current 2023-06-19 14:57:48 583
Current 2023-06-19 14:57:50 607
Current 2023-06-19 14:57:53 673
Current 2023-06-19 14:57:56 0,62
Current 2023-06-19 14:57:58 598

Can any-one shed light please ?

These are amperage readings. 0.62 amp is correct.

If it changed them all, no problem, then it's milliamps.
But it only changes some.

Decimal 'comma' ? Decimal 'period' ?

But why not all ?

@Rello Rello self-assigned this Jun 19, 2023
@Rello
Copy link
Owner

Rello commented Jun 20, 2023

Hi,
I will check. I think the logic gets confused with a comma and thousand separator

@motsumipower
Copy link
Author

Thanks.

@Rello
Copy link
Owner

Rello commented Jun 20, 2023

Realtime datasource on the csv file - correct:
Bildschirmfoto 2023-06-20 um 22 25 49

Dataload from csv file - wrong:
Bildschirmfoto 2023-06-20 um 22 26 32

I will fix the value parser here...

but one thing to add: the analytics reporting currently only uses 2 digits when storing the data in the internal database...

@motsumipower
Copy link
Author

Thanks. Noted. about the two digit value.

Observation :
Yes, it seems the only one that came in correctly was the two digit decimal
Current,2023-06-19 14:57:56.053952,0.62
Current 2023-06-19 14:57:56 0,62

I will try to get logging to round up.
Current,2023-06-19 14:57:40.307085,0.636
to
Current,2023-06-19 14:57:40.307085,0.64

@motsumipower
Copy link
Author

Success.

CSV as follows : (with 2 digit decimal)
successfully autoloads and refreshes.

Current,2023-06-21 05:13:36.533009,0.64
Current,2023-06-21 05:13:39.461932,0.66
Current,2023-06-21 05:13:42.041935,0.64
Current,2023-06-21 05:13:44.150528,0.65
Current,2023-06-21 05:13:46.245683,0.68
Current,2023-06-21 05:13:48.344914,0.67

image

@Rello
Copy link
Owner

Rello commented Jun 21, 2023

Hi,
yes, its a workaround. nevertheless the dataloader needs some correction here. it will do the rounding automatically then

@Rello Rello added enhancement Feature request in progress development in progress labels Jul 14, 2023
@Rello Rello added this to the 4.9.5 milestone Jul 14, 2023
@Rello
Copy link
Owner

Rello commented Jul 31, 2023

parser was corrected to deal with 0,xxx values and not treat them as 1000-separators

@Rello Rello changed the title Data is changed when loading it. "0.673" becomes 673 , but not all. 3digit comma values evaluated as 1000s Jul 31, 2023
@Rello Rello added pending release part of the next release version and removed in progress development in progress labels Jul 31, 2023
@Rello Rello removed the pending release part of the next release version label Aug 22, 2023
@Rello Rello closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request
Projects
None yet
Development

No branches or pull requests

2 participants