-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REG-1903] Drag and Drop Sequence Editor #271
Conversation
|
||
// check if this card is within a drop zone the moment it begins dragging. If so, this card is being | ||
// reordered or deleted, not added as a new child | ||
Vector2 mouseScreenSpacePosition = Input.mousePosition; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to do any special handling of these mouse input events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is seriously so awesome to see! Love the attention to detail, especially with that fade out deletion. Also appreciate the comments and code structure, was super easy to review. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea/Question: What should/does happen when we double click on a segment? In this view, do we have a way for the user to get more information about each segment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the drag/drop into a scrollable box. I've seen this done a few different ways, but one way is to treat the draggable area as a fixed area.
Then transform those coordinates into the scrollable component behind it based on its relative scroll position at the time.
A bit tedious/manual but reliable
@batu thanks for the great input!
|
The main focus of this PR is to establish the drag and drop interaction that will be used for creating and editing bot Sequences. The next PR will use real Segments, and will save the new Sequence
I apologize for the size of this PR. Luckily most of the changes are from new prefabs
What has been done
Out of Scope
LOOM
https://www.loom.com/share/1176801c9be147fd948630be6505a7af