Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1915] Implement bot segment action for clicking based on open vocab image queries. #267

Merged
merged 36 commits into from
Aug 29, 2024

Conversation

batu
Copy link
Contributor

@batu batu commented Aug 23, 2024

Loom video.

Related Unity Boss Room example.

Implement the bot segment action using image queries.


Find the pull request instructions here

Every reviewer and the owner of the PR should consider these points in their request (feel free to copy this checklist so you can fill it out yourself in the overall PR comment)

  • The code is extensible and backward compatible
  • New public interfaces are extensible and open to backward compatibility in the future
  • If preparing to remove a field in the future (i.e. this PR removes an argument), the argument stays but is no longer functional, and attaches a deprecation warning. A linear task is also created to track this deletion task.
  • Non-critical or potentially modifiable arguments are optional
  • Breaking changes and the approach to handling them have been verified with the team (in the Linear task, design doc, or PR itself)
  • The code is easy to read
  • Unit tests are added for expected and edge cases
  • Integration tests are added for expected and edge cases
  • Functions and classes are documented
  • Migrations for both up and down operations are completed
  • A documentation PR is created and being reviewed for anything in this PR that requires knowledge to use
  • Implications on other dependent code (i.e. sample games and sample bots) is considered, mentioned, and properly handled
  • Style changes and other non-blocking changes are marked as non-blocking from reviewers

@batu batu marked this pull request as ready for review August 27, 2024 00:04
Copy link
Collaborator

@vontell vontell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the other conversation around the matter of configuring this action. Just to reiterate in a different way from the other explanation, I'd rather have users thinking about this as one algorithm/approach.

Base automatically changed from cv/image_criteria to main August 28, 2024 21:17
@batu batu merged commit 41a1eb5 into main Aug 29, 2024
2 checks passed
@batu batu deleted the cv/image_action branch August 29, 2024 08:38
addisonbgross pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants