xyyCSD2BY1: do not ignore nonconvergence #955
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xBBCSD info output was ignored leaving callers unaware of convergence failures.
christoph-conrads
force-pushed
the
xyyCSD2BY1-ignores-nonconvergence
branch
from
8e7494e
to
42a470e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1930 1930
Lines 190055 190055
=======================================
Misses 190055 190055 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The xBBCSD info output was ignored leaving callers unaware of convergence failures. The problem is not present in the xyyCSD routines.
The issue was found while working on #943.
Checklist