Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation of LAPACKE possibly independent from Fortran #834

Conversation

weslleyspereira
Copy link
Collaborator

@weslleyspereira weslleyspereira commented May 24, 2023

Attempt to close #273.

#273 has an interesting idea in my view. If one needs only LAPACKE (for instance, if LAPACK is already installed), Fortran compiler may not be necessary. This PR is my first step towards this idea.

Still needs testing, so I am putting this as a Draft.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Attention: 413 lines in your changes are missing coverage. Please review.

Comparison is base (02ea2d3) 0.00% compared to head (3a86ff7) 0.00%.
Report is 3 commits behind head on master.

❗ Current head 3a86ff7 differs from pull request most recent head bf50aff. Consider uploading reports for the commit bf50aff to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #834   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1918     1918           
  Lines      188642   188645    +3     
=======================================
- Misses     188642   188645    +3     
Files Coverage Δ
SRC/chseqr.f 0.00% <ø> (ø)
SRC/cggglm.f 0.00% <0.00%> (ø)
SRC/cgglse.f 0.00% <0.00%> (ø)
SRC/cggqrf.f 0.00% <0.00%> (ø)
SRC/cggrqf.f 0.00% <0.00%> (ø)
SRC/chesv_aa_2stage.f 0.00% <0.00%> (ø)
SRC/chetrs_aa.f 0.00% <0.00%> (ø)
SRC/csysv_aa_2stage.f 0.00% <0.00%> (ø)
SRC/csytrf_aa_2stage.f 0.00% <0.00%> (ø)
SRC/csytrs_aa.f 0.00% <0.00%> (ø)
... and 203 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weslleyspereira weslleyspereira force-pushed the makes-cmake-independent-from-Fortran branch from 47a668e to 981af11 Compare October 31, 2023 17:23
@weslleyspereira
Copy link
Collaborator Author

Rebased with current master.

@weslleyspereira weslleyspereira force-pushed the makes-cmake-independent-from-Fortran branch from f2afb48 to bf50aff Compare October 31, 2023 17:59
@weslleyspereira weslleyspereira marked this pull request as ready for review October 31, 2023 18:00
@weslleyspereira
Copy link
Collaborator Author

I put a test in the CI, so it should be now good to merge

@langou langou merged commit 33b3a45 into Reference-LAPACK:master Oct 31, 2023
7 of 9 checks passed
@drhpc
Copy link

drhpc commented Jan 8, 2024

Oh, in #972 I added fixed Fortran language use in order to introduce optional C++ use. Might want to adapt that to fix both issues properly. My gripe was that suddenly CMake requires a working C++ compiler even without LAPACK++ or BLAS++. The pkgsrc build environment is picky and only provides the compilers a package claims to need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LAPACK option and support building only LAPACKE without requiring fortran
3 participants