Make the type of N_THREADS to be INTEGER*4 explicitly#597
Merged
Conversation
When building with -fdefault-integer=8, the type changes, but only some compiler like gfortran implements `omp_set_num_threads` with integer*8 input. When swapping the openmp library with LLVM openmp, this doesn't work yet. Until LLVM openmp is fixed explicitly setting the type fixes the build issue.
Contributor
|
Thanks @isuruf! Some references for where this is coming from: |
martin-frbg
previously approved these changes
Jul 14, 2021
Collaborator
|
appveyor failure is unrelated conda update problem - some kind of circular dependency between conda and tqdm. Suggest setting |
This was referenced Jul 15, 2021
weslleyspereira
approved these changes
Jul 15, 2021
This was referenced Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with -fdefault-integer=8, the type changes, but
only some compilers like gfortran implements
omp_set_num_threadswith integer*8 input. When swapping the openmp library with
LLVM openmp, this doesn't work yet. Until LLVM openmp is fixed
explicitly setting the type fixes the build issue.
Description
Checklist
cc @martin-frbg, @h-vetinari