Skip to content

Fix some incorrect SLASET/DLASET calls (includes backport of openblas#2778) #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julielangou merged 6 commits into from
Sep 8, 2020
Merged

Fix some incorrect SLASET/DLASET calls (includes backport of openblas#2778) #438

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0bba131
Fix incorrect calls to DLASET
martin-frbg Aug 13, 2020
7d8e2f0
Fix incorrect argument to SLASET
martin-frbg Aug 13, 2020
7744f9e
Fix incorrect argument to SLASET
martin-frbg Aug 13, 2020
a5bfdf8
Fix bounds-violation in SLASET
h-vetinari Sep 6, 2020
94994eb
Fix more bounds-violations in SLASET-calls
h-vetinari Sep 6, 2020
bffac66
Fix bounds-violations in DLASET-calls
h-vetinari Sep 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions TESTING/EIG/cchkhb2stg.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,8 +680,8 @@ SUBROUTINE CCHKHB2STG( NSIZES, NN, NWDTHS, KK, NTYPES, DOTYPE,
* the one from above. Compare it with D1 computed
* using the DSBTRD.
*
CALL DLASET( 'Full', N, 1, ZERO, ZERO, SD, 1 )
CALL DLASET( 'Full', N, 1, ZERO, ZERO, SE, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SD, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SE, 1 )

@h-vetinari h-vetinari Sep 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I compare the diff with the OP from #429, @serguei-patchkovskii actually suggested the following

Suggested change
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SD, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SE, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SD, N )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SE, N )

Was it intentional to implement this differently @martin-frbg?

CALL CLACPY( ' ', K+1, N, A, LDA, U, LDU )
LH = MAX(1, 4*N)
LW = LWORK - LH
Expand Down Expand Up @@ -753,8 +753,8 @@ SUBROUTINE CCHKHB2STG( NSIZES, NN, NWDTHS, KK, NTYPES, DOTYPE,
* the one from above. Compare it with D1 computed
* using the DSBTRD.
*
CALL DLASET( 'Full', N, 1, ZERO, ZERO, SD, 1 )
CALL DLASET( 'Full', N, 1, ZERO, ZERO, SE, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SD, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SE, 1 )
Comment thread
h-vetinari marked this conversation as resolved.
Outdated
CALL CLACPY( ' ', K+1, N, A, LDA, U, LDU )
LH = MAX(1, 4*N)
LW = LWORK - LH
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/schksb2stg.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,8 +670,8 @@ SUBROUTINE SCHKSB2STG( NSIZES, NN, NWDTHS, KK, NTYPES, DOTYPE,
* the one from above. Compare it with D1 computed
* using the SSBTRD.
*
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SD, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SE, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SD, N )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SE, N )
CALL SLACPY( ' ', K+1, N, A, LDA, U, LDU )
LH = MAX(1, 4*N)
LW = LWORK - LH
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/schkst2stg.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,8 +999,8 @@ SUBROUTINE SCHKST2STG( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
* the one from above. Compare it with D1 computed
* using the 1-stage.
*
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SD, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SE, 1 )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SD, N )
CALL SLASET( 'Full', N, 1, ZERO, ZERO, SE, N )
CALL SLACPY( "U", N, N, A, LDA, V, LDU )
LH = MAX(1, 4*N)
LW = LWORK - LH
Expand Down