NaN not propagating in DCOMBSSQ and SCOMBSSQ#390
Merged
Conversation
pdalgd
changed the title
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 83.24% 83.24% +<.01%
==========================================
Files 1808 1808
Lines 170181 170183 +2
==========================================
+ Hits 141664 141666 +2
Misses 28517 28517
Continue to review full report at Codecov.
|
pdalgd
changed the title
Contributor
|
Thanks! |
Collaborator
|
As a side effect this added a spurious .DS_Store file to the base directory (some kind of directory attribute storage on OSX apparently) |
Contributor
|
Fixed with 0b06227 |
Contributor
Author
|
Sorry about that, please remove. I blame my lacking github expertise. (Yes, MacOS creates those files all over the place.)
…-pd
On 23 Feb 2020, at 17:33 , Martin Kroeker ***@***.***> wrote:
As a side effect this added a spurious .DS_Store file to the base directory (some kind of directory attribute storage on OSX apparently)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
Peter Dalgaard, Professor,
Center for Statistics, Copenhagen Business School
Solbjerg Plads 3, 2000 Frederiksberg, Denmark
Phone: (+45)38153501
Office: A 4.23
Email: pd.mes@cbs.dk Priv: PDalgd@gmail.com
|
5 tasks
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
NaN not propagating in DCOMBSSQ and SCOMBSSQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S/DCOMBSSQ do not propagate NaN in some cases. The problem case is V1(1)=V2(1)=0 with V2(2)=NaN. Without the fix (the inner ELSE), control passes through without ever looking at V2(2). This was discovered in R (www.r-project.org), where a Frobenius norm (DLANGE) of the matrix
0 NA 0
0 0 -1
returns 1 with LAPACK 3.9.0 but gave NA with earlier versions.