Android bootstrap, NavigatorIOS -> Navigator throughout#4
Android bootstrap, NavigatorIOS -> Navigator throughout#4AndrewHamm merged 13 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Fine for now, in the future I will probably get rid of/change this since everything is not necessarily a show
There was a problem hiding this comment.
I was under the impression that show was the blanket term for either movie or TV show.
There was a problem hiding this comment.
Then this would make sense. Maybe "Reel" instead of show ?
There was a problem hiding this comment.
@BillyBarbaro it may be ambiguous but no more ambiguous/confusing than labeling a movie as a show. Plus, in the design mocks this page doesn't even have a header so it would be just for internal naming. And also then it would allow us to have more specific names for attributes like movies and shows which may contain different information. For example shows may list info about seasons and episodes while movies will not.
There was a problem hiding this comment.
also just saw Greg's comment about lolore so we have already kind of decided to call stuff movies by choosing to use lolomo.... hmmmm something to think about
There was a problem hiding this comment.
Ya i did like 2-3 hours of reading and coding while watching 30 Rock. So I was a bit distracted but I definitely think I'm closer to the right solution.
Android bootstrap, NavigatorIOS -> Navigator throughout
3 participants
all of these changes do not break any iOS functionality (well, we don't have tests so my metric is via manual navigation).
I can break apart some of the
index.ios.jscode.Also, this new system means that there may no longer be any need for
screens. Each tab now contains a navigator and the navigation bar is optional/customizable with each tab.