chore: update eslint to sort out imports (#1655)

* chore: update eslint to sort out imports

* turn warnings into errrors

.eslintrc.yml

@@ -12,6 +12,7 @@ parserOptions:
   sourceType: module
 plugins:
   - '@typescript-eslint'
+  - import
 rules:
   '@typescript-eslint/no-unused-vars':
     - error
@@ -20,10 +21,20 @@ rules:
   '@typescript-eslint/no-var-requires': off
   '@typescript-eslint/no-empty-function': off
   '@typescript-eslint/no-inferrable-types': off
-  '@typescript-eslint/ban-types': warn
+  '@typescript-eslint/ban-types': error
   '@typescript-eslint/no-explicit-any': warn # TODO: make it error!
   no-prototype-builtins: off
-  no-useless-escape: warn
+  no-useless-escape: error
+  '@typescript-eslint/consistent-type-imports':
+    - error
+    - prefer: type-imports
+  import/order:
+    - error
+    - groups:
+        - ['builtin', 'external', 'parent', 'sibling', 'index', 'object']
+        - [type]
+      'newlines-between': 'always'
+  import/no-duplicates: error
 ignorePatterns:
   - '**/__tests__/'
   - 'packages/*/lib/'

benchmark/package.json

@@ -24,7 +24,8 @@
     "cli-1.15": "npm:@redocly/[email protected]",
     "cli-1.16": "npm:@redocly/[email protected]",
     "cli-1.17": "npm:@redocly/[email protected]",
-    "cli-1.18": "npm:@redocly/[email protected]",
+    "cli-1.18": "npm:@redocly/[email protected]",
+    "cli-1.19": "npm:@redocly/[email protected]",
     "cli-next": "file:../redocly-cli.tgz"
   }
 }

jest.config.js

@@ -13,8 +13,8 @@ module.exports = {
   coverageThreshold: {
     'packages/core/': {
       statements: 80,
-      branches: 71,
-      functions: 73,
+      branches: 72,
+      functions: 74,
       lines: 80,
     },
     'packages/cli/': {