Skip to content

Fix use of key pos API, and point to first tensor key in command def #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lantiga merged 2 commits into from
Jul 18, 2019
Merged

Fix use of key pos API, and point to first tensor key in command def #161

lantiga merged 2 commits into from
Jul 18, 2019

Conversation

@lantiga
Copy link
Contributor

@lantiga lantiga commented Jul 18, 2019 •
edited
Loading

Addresses #160
/cc @MeirShpilraien

@lantiga lantiga requested a review from MeirShpilraien July 18, 2019 09:33
MeirShpilraien
MeirShpilraien reviewed Jul 18, 2019
View reviewed changes
src/redisai.c Outdated

if (RedisModule_IsKeysPositionRequest(ctx)) {
RedisModule_KeyAtPos(ctx, 1);
for (int i=1; i<argc; i++) {
Copy link

@MeirShpilraien MeirShpilraien Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you start from 2?

Copy link
Contributor Author

@lantiga lantiga Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn

MeirShpilraien
MeirShpilraien reviewed Jul 18, 2019
View reviewed changes
src/redisai.c Outdated

if (RedisModule_IsKeysPositionRequest(ctx)) {
RedisModule_KeyAtPos(ctx, 1);
for (int i=2; i<argc; i++) {
Copy link

@MeirShpilraien MeirShpilraien Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you start from 3?

MeirShpilraien
MeirShpilraien reviewed Jul 18, 2019
View reviewed changes
Copy link

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See small comments, other then this looks good.

@lantiga
Copy link
Contributor Author

lantiga commented Jul 18, 2019

Fixed, good catch :-)

@lantiga lantiga merged commit 45dbb80 into master Jul 18, 2019
@lantiga lantiga mentioned this pull request Jul 18, 2019
Closed
@gkorland gkorland deleted the keypos_fix branch July 18, 2019 11:11
lantiga added a commit that referenced this pull request May 6, 2020
@lantiga
9d8df93 
 
Fix use of key pos API, and point to first tensor key in command def (#161)

* Fix use of key pos API, and point to first tensor key in command def

* Fix offsets
@lantiga lantiga mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MeirShpilraien MeirShpilraien MeirShpilraien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lantiga @MeirShpilraien