Refactor query result - [MOD-5530] #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyAv46
force-pushed
the
guyav-refactor_query_result
branch
from
248b7bf
to
fb8df57
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 95.63% 95.56% -0.08%
==========================================
Files 66 65 -1
Lines 4174 4079 -95
==========================================
- Hits 3992 3898 -94
+ Misses 182 181 -1
☔ View full report in Codecov by Sentry. |
meiravgri
reviewed
Aug 6, 2023
There was a problem hiding this comment.
will done, looks like a really tidious PR
I do think that some re-organization needs to be done in the query results files
i suggest renaming query_result.h to query_result_c_api and divided it into query_result, query_list, and query_iterator sections.
I didn't quite understand why is query_result_struct belongs to a seperated file, maybe a btter naming would clearify its purpose.
meiravgri
previously approved these changes
Aug 6, 2023
Closed
GuyAv46
changed the title
GuyAv46
force-pushed
the
guyav-refactor_query_result
branch
from
5010fc2
to
52ab1e0
Compare
DvirDukhan
approved these changes
Aug 12, 2023
GuyAv46
added a commit
that referenced
this pull request
Aug 13, 2023
* remove `arr_cpp.h` and replace all its use cases with vectors * remove `uninitialized` from an error worthy warning in spaces * after rebase fixes * build fixes * another attempt * more build fixes * format * fix bindings * fix leak in test * some review fixes * remove `VecSimQueryResult` setters * renaming `query_result_struct.h` * generalize VecSimQueryResult_Iterator iterator * improved and aligned result collecting loop in bf_batch_iterator * use std::tie * remove error suppressing (seems to be fixed) * renaming `VecSimQueryResult` structures, introducing `VecSimQueryReply` * reordering comment * renaming * tidy up sorting functions * support for gcc-9 * rename VecSim_QueryResult_* codes
GuyAv46
added a commit
that referenced
this pull request
Aug 13, 2023
* remove `arr_cpp.h` and replace all its use cases with vectors * remove `uninitialized` from an error worthy warning in spaces * after rebase fixes * build fixes * another attempt * more build fixes * format * fix bindings * fix leak in test * some review fixes * remove `VecSimQueryResult` setters * renaming `query_result_struct.h` * generalize VecSimQueryResult_Iterator iterator * improved and aligned result collecting loop in bf_batch_iterator * use std::tie * remove error suppressing (seems to be fixed) * renaming `VecSimQueryResult` structures, introducing `VecSimQueryReply` * reordering comment * renaming * tidy up sorting functions * support for gcc-9 * rename VecSim_QueryResult_* codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Remove the
arr_cpp.harray implementation and moved to use vectors.Also, make
VecSimQueryResult_Listan opaque type and change the API to return a pointer to it instead of by value, and rename it toVecSimQueryReply.This PR enables compiling the library with GCC 12 and 13 as well.
Which issues this PR fixes
Main objects this PR modified
arr_cpp.himplementationMark if applicable