Priority queue iterator - [MOD-5529] #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyAv46
commented
Aug 3, 2023
| @@ -1655,140 +1655,6 @@ TYPED_TEST(HNSWTest, testInitialSizeEstimation_No_InitialCapacity) { | |||
| VecSimIndex_Free(index); | |||
| } | |||
|
|
|||
| TYPED_TEST(HNSWTest, testIncomingEdgesSize) { | |||
There was a problem hiding this comment.
This test is no longer needed as we now have no guarantee on the behavior of choosing between candidates with equal distance (aka choosing at random).
GuyAv46
force-pushed
the
guyav-priority_queue_iterator
branch
from
e14aafd
to
5753227
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
- Coverage 95.66% 95.61% -0.06%
==========================================
Files 66 66
Lines 4180 4174 -6
==========================================
- Hits 3999 3991 -8
- Misses 181 183 +2
☔ View full report in Codecov by Sentry. |
meiravgri
reviewed
Aug 6, 2023
meiravgri
approved these changes
Aug 6, 2023
DvirDukhan
approved these changes
Aug 8, 2023
GuyAv46
added a commit
that referenced
this pull request
Aug 8, 2023
* changed implementation of max heap to have random order iterator * changed heuristic use to use heap iterator * fix sort * bug fix (flip flag) * reserving and using ranges * removing a no-longer relevant test * making heap iterator const * remove the usage of ranges (TODO: return in the future) * review fixes
GuyAv46
added a commit
that referenced
this pull request
Aug 9, 2023
* changed implementation of max heap to have random order iterator * changed heuristic use to use heap iterator * fix sort * bug fix (flip flag) * reserving and using ranges * removing a no-longer relevant test * making heap iterator const * remove the usage of ranges (TODO: return in the future) * review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This PR exposes a random order iterator for the
max_priority_queue, and utilizes it in the neighbor choosing heuristic in HNSW. This improvement reduces heap usage upon insertion and deletion.As a side effect, we no longer prefer the candidate with the larger internal id on equal distance candidates, and we choose "randomly" (we sort the candidates by score alone).
Main objects this PR modified
begin()andend()ofmax_priority_queueMark if applicable